Use passed ItemStack when inserting hand into the item hatch#10466
Open
vercte wants to merge 1 commit into
Open
Use passed ItemStack when inserting hand into the item hatch#10466vercte wants to merge 1 commit into
vercte wants to merge 1 commit into
Conversation
vercte
added
area: compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Item Hatch directly modify the passed item stack when right-clicked if the player is depositing the item in their hand. This prevents unexpected behaviour with my mod Satchels, as described in vercte/satchels#3:
Before these changes, it would always deposit the selected slot in the normal hotbar, which may be unexpected to the player as their held item would not be deposited and the slot below the satchel would be. These changes always deposit the held item correctly instead of directly checking the player inventory.