Fix voxel entity collision for air currents#10380
Open
antessial wants to merge 1 commit into
Open
Conversation
antessial
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9416 and #10292, tested on sawmills, pistons and drills
Not sure how does it work exactly on the lib side, but my best guess is it checked the wrong pixel because coordinates get rounded down to the closest real coordinate. Consider there to be 16 "pixels", 0 is the first "pixel", 0.25 correspond to "pixel" 5, while 0.2499 is "pixel" 4 and 0.75 is "pixel" 13. Now it should check at the same distance from all sides of the voxel, even if there would be more than 16 "pixels", 0.2499 precision should be more than enough for that
Compressed video demonstration: https://github.com/user-attachments/assets/b6f7f317-4eb3-4b3c-b02e-b0239994bcd6