CONT-93: Forecast microservice#89
Open
alperhi wants to merge 2 commits into
Open
Conversation
Henning-Schulz
left a comment
Henning-Schulz
left a comment
Contributor
There was a problem hiding this comment.
If I get it correctly, these files should be removed:
- continuity.forecast/telescope-multi/R/.RData
- continuity.forecast/telescope-multi/R/.Rhistory
Henning-Schulz
left a comment
Henning-Schulz
left a comment
Contributor
There was a problem hiding this comment.
I guess also all the files in continuity.forecast/telescope-multi/R/logs/ should be removed.
Henning-Schulz
requested changes
Nov 14, 2018
Henning-Schulz
left a comment
Henning-Schulz
left a comment
Contributor
There was a problem hiding this comment.
Looks almost good, but there are some minor flaws which should be corrected.
| compile project(':continuity.api') | ||
| compile project(':continuity.commons') | ||
|
|
||
| compile files('lib/behaviormodelextractor_forecast.jar') |
Contributor
There was a problem hiding this comment.
We should upload this to the Nexus as a new version
Contributor
There was a problem hiding this comment.
+1 I also need this for my workload modularization approach
| - --eureka.uri=http://eureka:8761/eureka | ||
|
|
||
| forecast: | ||
| image: continuityproject/session-logs |
Contributor
There was a problem hiding this comment.
Should it be continuityproject/forecast?
Henning-Schulz
approved these changes
Nov 16, 2018
Contributor
|
@Henning-Schulz, could you please wait to integrate this. I'll create a pull request which consists of CONT-93 and CONT-126. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.