Skip to content

clustering support for ignored host list - #187

Merged
ibrahimkk-moideen merged 11 commits into
mainfrom
add_ignoredhost_memberlist
Sep 18, 2026
Merged

ibrahimkk-moideen merged 11 commits into
mainfrom
add_ignoredhost_memberlist

Conversation

@ibrahimkk-moideen

Copy link
Copy Markdown
Collaborator

This PR adds clustering support for ignored host list.

@ibrahimkk-moideen ibrahimkk-moideen linked an issue Sep 14, 2026 that may be closed by this pull request
@ibrahimkk-moideen
ibrahimkk-moideen marked this pull request as ready for review September 14, 2026 15:36
@ibrahimkk-moideen

Copy link
Copy Markdown
Collaborator Author

Go local tests:

PASS
ok  	github.com/comcast/fishymetrics/exporter	0.530s

@derrick-dacosta derrick-dacosta left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for seven functionality, scalability, and security issues detailed inline. Reviewed commit 500481b; vendor/ was excluded from review.

The main blockers are credential redirection through the new add endpoint and non-atomic local/replicated state updates. Additional issues affect conflict convergence, default advertised addresses, partition recovery, IPv6 discovery, and unbounded removal history.

Validation: existing targeted package tests passed (gossip, common, exporter/..., http/handlers, cmd/fishymetrics). Six isolated reproductions confirmed findings 1-6 using a temporary copy and fake credentials/local listeners. Tombstone growth was established by inspection of the retention and full-state synchronization paths. No repository source changes were made.

Comment thread common/cluster_handlers.go Resolved
Comment thread common/ignored.go Resolved
Comment thread gossip/manager.go Resolved
Comment thread cmd/fishymetrics/main.go Resolved
Comment thread gossip/manager.go Resolved
Comment thread gossip/discovery.go Resolved
Comment thread gossip/manager.go Resolved

@derrick-dacosta derrick-dacosta left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahimkk-moideen
ibrahimkk-moideen merged commit 3b3124f into main Sep 18, 2026
4 checks passed
@ibrahimkk-moideen
ibrahimkk-moideen deleted the add_ignoredhost_memberlist branch September 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clustering support for Ingored host list

2 participants