Repository navigation
clustering support for ignored host list - #187
Conversation
|
Go local tests: |
There was a problem hiding this comment.
Requesting changes for seven functionality, scalability, and security issues detailed inline. Reviewed commit 500481b; vendor/ was excluded from review.
The main blockers are credential redirection through the new add endpoint and non-atomic local/replicated state updates. Additional issues affect conflict convergence, default advertised addresses, partition recovery, IPv6 discovery, and unbounded removal history.
Validation: existing targeted package tests passed (gossip, common, exporter/..., http/handlers, cmd/fishymetrics). Six isolated reproductions confirmed findings 1-6 using a temporary copy and fake credentials/local listeners. Tombstone growth was established by inspection of the retention and full-state synchronization paths. No repository source changes were made.
This PR adds clustering support for ignored host list.