🧪 test(ci): gate Playwright on QA fixture readiness

[scttbnsn]

Rescued from the fix/playwright-qa-readiness worktree during the main↔dev reconciliation audit — this commit had reached neither branch and would have been lost when that worktree was cleaned up.

It's the root-cause fix for the Playwright flake that burned an rc.5 cut cycle (apiRequestContext.post: Timeout 45000ms on the notification-bell spec, plus the intermittent "Start drydock" Cucumber failures).

What it does

• e2e/playwright/auth.setup.ts — auth setup now polls /api/v1/containers until the complete 29-container QA fixture snapshot is present (specific named containers with their dd.group labels and a populated result) before writing storageState. Previously specs could start against a half-populated store, so assertions raced the startup watcher scan. 180s poll budget at 2s intervals, setup timeout raised to 240s.
• test/qa-compose.yml — parks the local and remote watcher crons on 0 0 29 2 * with JITTER=0 and WATCHEVENTS=false, so no scheduled or event-driven rescan can mutate fixtures mid-suite. The startup scan still runs; only the later races are removed.
• .github/tests/e2e-playwright-workflow.test.ts — coverage asserting the readiness gating stays wired up.

Verification

Full pre-push gate green: clean-tree, ts-nocheck, biome, qlty, qlty-smells, scripts-test, workflow-tests (9 files / 46 tests), typecheck-ui, coverage (app + ui both at 100%), build.

✨ Added

• Playwright fixture-readiness gating for 29 expected QA containers before saving storageState.
• Workflow test coverage for setup sequencing and readiness configuration.
• Documentation of the startup race and cold-stack validation.

🔧 Changed

• Increased Playwright setup timeout to 240 seconds with a 180-second readiness polling budget.

• Disabled scheduled and event-driven watcher rescans during browser tests while preserving the startup scan.

• Added required container, label, result, and update-availability checks.

• Readiness validation is tightly coupled to a hardcoded set of 29 containers and labels.

• The 0 0 29 2 * watcher schedule should remain intentional and documented as a disabled schedule.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
drydock-website	Ready	Preview, Comment	Jul 24, 2026 12:20pm
drydockdemo-website	Ready	Preview, Comment	Jul 24, 2026 12:20pm

[coderabbitai]

📝 Walkthrough

Walkthrough

Playwright authentication setup now polls /api/v1/containers?limit=100 until required QA containers and update data are present. The QA compose fixture disables event-driven refreshes and parks watcher cron jobs. Workflow tests validate step ordering, setup readiness logic, and watcher configuration. Reliability documentation records the startup race and cold-stack validation result.

Possibly related PRs

• CodesWhat/drydock#585: Implements the same 29-container Playwright readiness gate and watcher refresh configuration.
• CodesWhat/drydock#550: Both changes update Playwright workflow step-order validation.
• CodesWhat/drydock#527: Covers the versioned /api/v1/containers readiness endpoint used by the auth setup.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/v1.6-playwright-fixture-readiness

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@e2e/playwright/auth.setup.ts`:
- Around line 24-46: Update the fixture validation logic around the container
checks to define all 29 expected displayName/group entries and verify every
entry is present. Preserve the update-result validation only for fixtures that
require updates, rather than applying it globally, so missing or unenriched
fixtures cannot pass through sentinel checks.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b8122f05-6444-409d-87df-961248380706

📥 Commits

Reviewing files that changed from the base of the PR and between c2707f7 and d227b4f.

⛔ Files ignored due to path filters (1)

• CHANGELOG.md is excluded by !CHANGELOG.md

📒 Files selected for processing (4)

• .github/tests/e2e-playwright-workflow.test.ts
• docs/cucumber-reliability.md
• e2e/playwright/auth.setup.ts
• test/qa-compose.yml