Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe#1274
Open
shafiekwalker7861 wants to merge 1 commit into
Open
Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe#1274shafiekwalker7861 wants to merge 1 commit into
shafiekwalker7861 wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
shafiekwalker7861
changed the title
shafiekwalker7861
added
📅 Sprint 2
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 18, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great work, this page is almost complete. Just one small issue with the footer - see my other comment
| - [✅] The page scores 100 for Accessibility in the Lighthouse audit. | ||
| - [✅] The page header includes a title and description. | ||
| - [✅] The articles section has three unique articles, each including an image, title, summary, and a link. | ||
| - [✅] The page footer is fixed to the bottom of the viewport. |
There was a problem hiding this comment.
The criteria here says "fixed to the bottom of the viewport". Right now the footer is fixed to the bottom of the page. Do you know the difference between "fixed to viewport" and "fixed to page"?
LonMcGregor
added
Reviewed
I see you only made a single commit once the task was complete. It is OK to make smaller commits incrementally as you make changes instead of one big commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cape Town | 26-ITP-May | Shafiek Walker | Sprint 2 | Wireframe
Self checklist
Changelist
Created a wireframe webpage using semantic HTML and CSS
Added sections explaining wireframes, Git branches, and README files
Styled the page layout and added images
Practiced Git branching and pull request workflow
Questions
This is my first clean pull request workflow, so any feedback on structure or Git usage would be appreciated.