Skip to content

fix(DateDetails): use resolved timezone after fallback - #1158

Open
fallintoplace wants to merge 1 commit into
ClickHouse:mainfrom
fallintoplace:fix/date-details-invalid-timezone-fallback
Open

fix(DateDetails): use resolved timezone after fallback#1158
fallintoplace wants to merge 1 commit into
ClickHouse:mainfrom
fallintoplace:fix/date-details-invalid-timezone-fallback

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • keep track of the timezone that DateDetails actually resolves
  • use the New York fallback for both date and timezone formatting
  • cover invalid system timezones with a regression test

Why

DateDetails catches an invalid systemTimeZone and creates a New York time, but then passes the original invalid timezone back into the render-time formatters. Opening the popover therefore still throws a RangeError instead of displaying the fallback.

Validation

  • yarn vitest run src/components/DateDetails/DateDetails.test.tsx
  • yarn typecheck
  • focused ESLint check for the changed DateDetails files
  • yarn format

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 96e4d50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fallintoplace
fallintoplace force-pushed the fix/date-details-invalid-timezone-fallback branch from 3c4e459 to 96e4d50 Compare July 30, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant