fix(Pagination): prevent NaN when page input is cleared - #1157
Open
fallintoplace wants to merge 1 commit into
Open
fix(Pagination): prevent NaN when page input is cleared#1157fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 1c8b465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fallintoplace
changed the title
fallintoplace
force-pushed
the
fix/pagination-empty-page-input
branch
from
July 30, 2026 17:58
efb221a to
1c8b465
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Clearing the page input makes
parseIntreturnNaN. Since comparisons withNaNare always false, the existing minimum and maximum checks allow it through toonChange, where consumers can store an invalid page number.What changed?
NaNbefore applying the existing range checksonChangeis not calledValid page numbers keep their current behavior, including truncating decimal input.
Validation
yarn test --runyarn typecheckyarn lintyarn build