fix(datafusion): keep hot runs in one session#833
Open
kumarUjjawal wants to merge 1 commit intoClickHouse:mainfrom
Open
fix(datafusion): keep hot runs in one session#833kumarUjjawal wants to merge 1 commit intoClickHouse:mainfrom
kumarUjjawal wants to merge 1 commit intoClickHouse:mainfrom
Conversation
16 tasks
Author
|
@qoega If I could get your eyes on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the partitioned DataFusion runner so hot runs are really hot. See apache/datafusion#21696
Before this change, the script started a new
datafusion-cliprocess for every try. That made each try use a cold process, so tries 2 and 3 did not keep the warmed metadata cache.What changed
create.sqland the same query 3 timesdatafusion-clisessionElapsedlines fromcreate.sqlnullinstead of mixing in setup timingsThis follows the same main idea used by the DuckDB partitioned runner: one process per query, with repeated runs inside that process.
Thank you for review 🙏
Thank You for Your Contribution!
We appreciate your effort and contribution to the project. To ensure that your Pull Request (PR) adheres to our guidelines, please ensure to review the rules mentioned in our contribution guidelines:
ClickHouse/ClickBench Contribution Rules
Thank you for your attention to these details and for helping us maintain the quality and integrity of the project.