Skip to content

fix dev branch not working#4651

Merged
ChrisTitusTech merged 2 commits into
ChrisTitusTech:mainfrom
GabiNun2:patch-5
Jun 8, 2026
Merged

fix dev branch not working#4651
ChrisTitusTech merged 2 commits into
ChrisTitusTech:mainfrom
GabiNun2:patch-5

Conversation

@GabiNun2

@GabiNun2 GabiNun2 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • UI/UX improvement

Description

Fixes

PS C:\Users\User> irm christitus.com/windev | iex
Invoke-Expression:
Line |
   4 |/winutil/releases/download/$latestTag/winutil.ps1 | Invoke-Expression
     |                                                        ~~~~~~~~~~~~~~~~~
     | The attribute cannot be added because variable Preset with value  would no longer be valid.
PS C:\Users\User>

Issue related to PR

@GabiNun2 GabiNun2 requested a review from ChrisTitusTech as a code owner June 6, 2026 05:15
@github-actions github-actions Bot added the bug Something isn't working label Jun 6, 2026
This was referenced Jun 6, 2026
@jnsh-rf

jnsh-rf commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

maybe something like this would work instead?

$validPresets = @("Standard", "Minimal", "Advanced")
if ($Preset -and $Preset -notin $validPresets) {
    Write-Host "Error: Preset '$Preset' is invalid. Must be one of: $($validPresets -join ', ')" -ForegroundColor Red
    exit 1
}

@GabiNun2

GabiNun2 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

maybe something like this would work instead?

$validPresets = @("Standard", "Minimal", "Advanced")
if ($Preset -and $Preset -notin $validPresets) {
    Write-Host "Error: Preset '$Preset' is invalid. Must be one of: $($validPresets -join ', ')" -ForegroundColor Red
    exit 1
}

i mean it's whatever it will just fail if the preset is incorrect

@jnsh-rf

jnsh-rf commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

fixed in #4653 while preserving the params

@GabiNun2

GabiNun2 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

fixed in #4653 while preserving the params

you didn't even test it do you know how i know? because i tested it and it dosen't work

@jnsh-rf

jnsh-rf commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

There is literally section in PR desc that describe testing. Doing direct irm https://christitus.com/windev | iex breaks beacuse it points to current github windev.ps1 and that to latest stable release of winutil (section of start.ps1 pointed in PR desc).

@GabiNun2

GabiNun2 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

There is literally section in PR desc that describe testing. Doing direct irm https://christitus.com/windev | iex breaks beacuse it points to current github windev.ps1 and that to latest stable release of winutil (section of start.ps1 pointed in PR desc).

here is what i did i downloaded winutil localy than i complied winutil with the fix than took the contents of winutil.ps1 put it inside a github gist than i used irm | iex with the the url and it worked if i do the same thing without this fix it won't work

@GabiNun2 GabiNun2 mentioned this pull request Jun 7, 2026
4 tasks
@jnsh-rf

jnsh-rf commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
 [ValidateSet("Standard", "Minimal", "Advanced", "")]

If you want to validate, adding " " will work.

-Preset with nothing after will complain about not providing a string, which would happen anyway

@GabiNun2

GabiNun2 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author
 [ValidateSet("Standard", "Minimal", "Advanced", "")]

If you want to validate, adding " " will work.

-Preset with nothing after will complain about not providing a string, which would happen anyway

yeah that fixed it thank you

@ChrisTitusTech ChrisTitusTech merged commit daf0453 into ChrisTitusTech:main Jun 8, 2026
5 checks passed
@GabiNun2 GabiNun2 deleted the patch-5 branch June 8, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windev doesn't open

3 participants