Skip to content

Session timeout modal test timings - #2257

Open
sricharan-varanasi wants to merge 57 commits into
developfrom
session-timeout-modal-test-timings
Open

Session timeout modal test timings#2257
sricharan-varanasi wants to merge 57 commits into
developfrom
session-timeout-modal-test-timings

Conversation

@sricharan-varanasi

Copy link
Copy Markdown
Contributor

📝 Description

🔗 Jira Ticket M2-#

Changes include:

  • [Thing]
  • [Other thing]
  • [More things]

📸 Screenshots

Before (Optional) After

🪤 Peer Testing

✏️ Notes

✅ Checklist

Functionality

  • The feature behaves correctly in practice and fulfills the intended business purpose
  • The implementation accounts for edge cases, avoids subtle logical errors, and handles somewhat rare failure states (e.g. offline mode for mobile, 3rd party being down, etc)

Testing

  • Verify there are automated tests added that meaningfully cover critical behavior and failure cases
  • Code coverage does not go down as result of this change
  • Test suite passes

Security & Data Privacy

  • Verify there is no chance we would accidentally log PII to application logs
  • Verify this addition does not materially affect our security attack surface, and if so it has undergone security review
  • All inputs are sanitized
  • New dependencies are well maintained, have significant justification for being added to the project, and are documented in the Curious open source credit page

Logging/Monitoring

  • Logging is implemented for this change such that you could troubleshoot this feature in production
  • The change/feature is able to be monitored in production

Performance

  • This change does not introduce n+1 queries or other performance issues within our expected scale (e.g. missing indexes on frequently queried columns, frequently updating tables that are accessed often)

Readability

  • All commented out code is removed
  • Debugging code including extraneous log lines are removed
  • Code is easy to understand through naming and structure; comments explain intent or non‑obvious decisions

Change Safety

  • Backend changes are backwards compatible with old clients, or it is well known they are not and a deployment/rollout plan is in place. This include backend changes being compatible with old mobile app versions, as well as applet versioning within Curious.
  • Destructive database migrations are rolled out in stages. For example, renaming a column means adding a new column and migrating the existing data to that columns in one deployment. Then monitoring to ensure that field isn’t used, and finally removing that old column in a separate deployment.

@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from 5165bd1 to fa2aeb4 Compare August 24, 2026 22:35
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from fa2aeb4 to 94f1faa Compare August 25, 2026 22:01
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from 94f1faa to e55d439 Compare August 28, 2026 04:03
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from e55d439 to 63c01d4 Compare August 31, 2026 01:24
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from 63c01d4 to eb71cd4 Compare September 1, 2026 04:47
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from eb71cd4 to eef8488 Compare September 1, 2026 05:00
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from eef8488 to 58ad6d4 Compare September 1, 2026 06:42
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from 58ad6d4 to 2dea43a Compare September 1, 2026 06:58
@sricharan-varanasi
sricharan-varanasi force-pushed the session-timeout-modal-test-timings branch from 2dea43a to 8db2647 Compare September 1, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Pull request cannot be merged for some reason Do not review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants