Repository navigation
PAINTROID-723: Fix CircularProgressIndicator animation on landing page - #176
Open
aryanorastar wants to merge 1 commit into
Open
aryanorastar wants to merge 1 commit into
aryanorastar wants to merge 1 commit into
Conversation
Cache the projects Future so FutureBuilder does not restart the indicator on every rebuild. Refresh after returning from Pocket Paint and when ProjectDatabase is invalidated.
aryanorastar
force-pushed
the
bug/PAINTROID-723-progress-indicator-animation
branch
from
August 16, 2026 06:27
7845df8 to
05f792c
Compare
juliajulie95
requested changes
Sep 30, 2026
| }, | ||
| ); | ||
|
|
||
| testWidgets( |
Contributor
There was a problem hiding this comment.
I don't think this test catches the regression. Nothing rebuilds LandingPage while the completer is pending, because the bare tester.pump() calls don't trigger a rebuild. On develop, the build during loading fails on the uninitialized database before it reaches the mock, so getProjects() is called exactly once there as well. called(1) would pass without the fix.
| } | ||
|
|
||
| void _refreshProjectsFuture() { | ||
| _projectsFuture = _getProjects(); |
Contributor
There was a problem hiding this comment.
Now that the future is cached, one failed getProjects() call leaves the page on the spinner .
Could we handle the error state, e.g. show an error or retry option when snapshot.hasError, or reset _projectsFuture on error? This is fine as a follow-up if it's out of scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://catrobat.atlassian.net/browse/PAINTROID-723
New Features and Enhancements
Refactorings and Bug Fixes
_getProjects()future intoFutureBuilderon every rebuild, which restartedCircularProgressIndicatorand made the spinner look stuck / non-animated.Futureon State; recreate it when returning from Pocket Paint and whenProjectDatabaseis replaced after invalidate (delete/rename).getProjects()again.Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
Verification
flutter test test/widget/landing_page/landing_page_test.dart— 21/21 passed