Auto-call coin flips for win/lose outcomes#10533
Open
RafaelHGOliveira wants to merge 1 commit intoCard-Forge:masterfrom
Open
Auto-call coin flips for win/lose outcomes#10533RafaelHGOliveira wants to merge 1 commit intoCard-Forge:masterfrom
RafaelHGOliveira wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
Adds UI_AUTO_CALL_COIN_FLIP preference (default true) that skips the Heads/Tails prompt for coin flips where only the win/lose result matters (e.g. Krark's Thumb, Frenetic Efreet). The mathematical outcome is unaffected: any call has 50/50 odds, so auto-calling Heads removes a redundant click without changing game state. Behavior: - chooseBinary(HeadsOrTails): returns true (Heads) when pref is enabled. - chooseFlipResult: when call=true (Krark replacement effect), returns true to keep the matching result and guarantee the called side. NoCall flips still prompt the player. Players who prefer to choose each call can disable the pref via Settings -> Gameplay Preferences -> Auto-Call Coin Flips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new preference Auto-Call Coin Flips (default on) that skips the Heads/Tails prompt for coin flips where only the win/lose outcome matters (e.g. Krark's Thumb, Frenetic Efreet, Mana Clash, Goblin Bomb).
The mathematical outcome is unchanged: any call on a fair coin has 50/50 odds, so auto-calling Heads simply removes a redundant click that the player would have to make every flip. Cards where Heads vs Tails actually matters (no
call) still prompt as before.Motivation
In games with cards like Krark's Thumb, the player is asked twice per flip — once for the call, then once to pick which of the two results to keep. The call is mechanically meaningless on its own (50/50), and the player almost always picks Heads followed by the Heads result. This is repetitive in long games, especially Commander matches. Power players who want full manual control can disable the preference.
Behavior
chooseBinary(HeadsOrTails)— returnstrue(Heads) when the preference is enabled.chooseFlipResult(..., call)— whencall == true(the Krark-style replacement effect picks one of two flips to keep), returnstrueto keep the matching result and guarantee the called side. Whencall == false(Win/Lose-the-flip choice that doesn't depend on the call), the player is still prompted.Implementation
ForgePreferences.javaUI_AUTO_CALL_COIN_FLIPpref, defaulttruePlayerControllerHuman.javachooseBinaryandchooseFlipResultVSubmenuPreferences.javaCSubmenuPreferences.javaen-US.propertiescbAutoCallCoinFlip,nlAutoCallCoinFlip)Test plan
mvn -B compile -pl forge-gui-desktop -am -DskipTests— clean build