feat: improve user api for DTO JSON models#457
Closed
obemu wants to merge 5 commits into
Closed
Conversation
This commit effectively changes the discriminator property in the generated models from a `final` field to a getter that returns the static value for this variant.
Contributor
Author
|
@Carapacik how we lookin? |
obemu
force-pushed
the
feat-improve_json_dto
branch
from
d4e976f to
6e4a830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit effectively changes the discriminator property in the generated models from a
finalfield to a getter that returns the static value for this variant.