feat(desktop): deeplink recording controls + Raycast extension (#1540)#1741
Open
Leviann wants to merge 5 commits intoCapSoftware:mainfrom
Open
feat(desktop): deeplink recording controls + Raycast extension (#1540)#1741Leviann wants to merge 5 commits intoCapSoftware:mainfrom
Leviann wants to merge 5 commits intoCapSoftware:mainfrom
Conversation
…eplink parse logging - Use rundll32 url.dll,FileProtocolHandler on Windows (cmd start mangles % in query)\n- Move extension icon to assets/ (512px from app icon); README note\n- Refresh command toast with dev vs prod cache paths\n- Log parse/execute failures with tracing::warn for cap-desktop.log
Author
|
Update: pushed \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
cap-desktop://actiondeeplinks for recording controls and adds a Raycast extension underextensions/cap/.Deeplinks (Rust,
deeplink_actions.rs)pause_recording,resume_recording,toggle_pause_recordingtake_screenshot(samecapture_modeshape asstart_recording)set_microphone,set_camerarefresh_raycast_device_cachewritesraycast-device-cache.jsonin Cap app data (displays, windows, cameras, mics)Fix
cap-desktop://action?...was incorrectly rejected when the host wasaction(fall-through to Invalid). Parsing now requireshost_str() == "action".Raycast
Commands call
open(cap-desktop://action?value=...)with snake_case JSON matchingDeepLinkAction. Includes start/stop/pause/resume/toggle, refresh cache, screenshot, set mic/camera.Testing
npm install+tsc --noEmitinextensions/cap(Windows).cargo check -p cap-desktopwas not completed on this Windows agent (no MSVClink.exe; GNU path hits ffmpeg pkg-config). Expect macOS / project CI to validate the Rust crate.Related: #1540
/claim #1540
Greptile Summary
This PR extends
cap-desktop://actiondeeplinks with pause/resume/toggle-pause, take-screenshot, set-microphone, set-camera, and a device-cache refresh action on the Rust side, and adds a companion Raycast extension (extensions/cap/) with a command for each action. It also fixes a pre-existing URL-parsing bug whereurl.domain()withSome("action")fell through to the_ => Invalidarm, silently dropping every action deeplink.Confidence Score: 5/5
Safe to merge; all remaining findings are P2 style suggestions with no correctness impact.
The Rust handler implementations correctly delegate to existing recording functions, the URL host-check fix is clearly correct, and the Raycast extension is straightforward. The two open items (blocking std::fs I/O in async, missing error surface in the deeplink helper) are minor best-practice notes that don't affect correctness or data integrity.
No files require special attention; the blocking I/O note in deeplink_actions.rs is low-risk for a cache-write path.
Important Files Changed
Sequence Diagram
sequenceDiagram participant R as Raycast Extension participant OS as macOS open() participant T as Tauri deeplink handler participant DA as deeplink_actions.rs participant Rec as recording.rs R->>OS: open(cap-desktop://action?value=JSON) OS->>T: URL event T->>DA: handle(urls) DA->>DA: host_str() == "action"? parse ?value= JSON alt pause / resume / toggle DA->>Rec: pause_recording / resume_recording / toggle_pause_recording else take_screenshot DA->>DA: capture_target_from_mode() DA->>Rec: take_screenshot(app, target) else set_microphone / set_camera DA->>Rec: set_mic_input / set_camera_input else refresh_raycast_device_cache DA->>Rec: list_capture_displays / list_capture_windows / list_cameras DA->>DA: MicrophoneFeed::list() DA->>DA: std::fs::write(raycast-device-cache.json) end Rec-->>DA: Result DA-->>R: (fire-and-forget)Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat(desktop): deeplink recording contro..." | Re-trigger Greptile