Skip to content

Rotation Reimplement#649

Open
KivalEvan wants to merge 28 commits into
Caeden117:devfrom
KivalEvan:rotation-reimplement
Open

Rotation Reimplement#649
KivalEvan wants to merge 28 commits into
Caeden117:devfrom
KivalEvan:rotation-reimplement

Conversation

@KivalEvan

@KivalEvan KivalEvan commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

a bit overdue but it's getting closer

  • reimplements rotation event lane back in
  • v4 object rotation can be edited
    • Alt+Q and Alt+E to rotate CCW and CW while hovering object
      • applicable to rotation event
    • Ctrl+Alt+Q and Ctrl+Alt+E to rotate grid CCW and CW
      • in v4, this applies grid rotation to placement object lane rotation
      • in pre-v4, early rotation event is placed/modified/deleted instead
    • Alt+R to copy grid rotation to object
    • Ctrl+Alt+R to copy object rotation to grid
    • selectively choose which object type to follow
    • rotation text indicator
  • grid and camera follows v4 object rotation during playback
    • use average rotation for object of same time
    • uses editing rotation when not playing
  • smoother camera rotation follow
    • reduced motion option available

todo:

  • lane rotation line indicator (similar to game 360 line indicator)
  • idk what else i missed, probably check if i messed up elsewhere without realising

KivalEvan added 14 commits May 11, 2026 22:37
@KivalEvan
Implement v4 object rotation
caec2b2
@KivalEvan
Add lane indicator for note
50b4468
@KivalEvan
Revert version check maybe
819e0f9
@KivalEvan
Reimplement rotation event lane
8a5c2a9
@KivalEvan
Remove note lane indicator
48da648
@KivalEvan
Implement lane rotation provider
07d9ea3
@KivalEvan
Fix lane rotation incorrectly update on modify
cfd2ee1
@KivalEvan
Remove old rotation callback controller
75b8562
@KivalEvan
Handle rotation event lane visibility
bbd2b57
@KivalEvan
Fix rotation value return wrong event value
1967049
@KivalEvan
Merge branch 'dev' into rotation-reimplement
6b76dde 
# Conflicts:
#	Assets/Input/Master.cs
#	Assets/Input/Master.inputactions
#	Assets/__Scenes/03_Mapper.unity
#	Assets/__Scripts/Actions/IMergeableAction.cs
#	Assets/__Scripts/Editor/Grid/Placements/NotePlacement.cs
@KivalEvan
Fix action update not applying
7a04749
@KivalEvan
Fix and improve lane rotation smoothing
c534e96
@KivalEvan
Fix regression test
caa5308
@KivalEvan KivalEvan marked this pull request as ready for review June 23, 2026 14:45
XAce1337manX
XAce1337manX reviewed Jun 27, 2026
View reviewed changes
Comment thread Assets/__Scripts/Beatmap/Base/BaseNote.cs
// Compare by angle offset if cut direction
if (comparison == 0) comparison = AngleOffset.CompareTo(note.AngleOffset);

// genuinely why is the comment needed?

@XAce1337manX XAce1337manX Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Honestly should just purge these compare by comments.

@KivalEvan KivalEvan force-pushed the rotation-reimplement branch from acd757c to cb042c5 Compare June 28, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XAce1337manX XAce1337manX XAce1337manX approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KivalEvan @XAce1337manX