Repository navigation
Fix deprecation warnings in monitors service - #1805
Merged
annamontare-nava merged 2 commits intoNov 16, 2026
Merged
Conversation
ryan-morosa
approved these changes
Nov 16, 2026
ryan-morosa
left a comment
Contributor
There was a problem hiding this comment.
Validation worked as described! Had to do some initial set up since I haven't used tofu much but I don't see the deprecation warnings anymore. Even saw the difference when looking at it on master too.
annamontare-nava
deleted the
anna/fix-deprecation-warnings-in-monitors-service
branch
November 16, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
n/a
What Does This PR Do?
This PR fixes deprecation warnings in the output of tofu actions on the monitors service.
It does this by only selecting the attributes of objects that are actually used, since otherwise tofu will give errors.
Note that we weren't actually using the deprecated attributes, tofu just sees them as part of an object we create and complains.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
tofu planon each environment for the30-monitorsservice. You should see only two deprecation warnings from the platform module (which I did not touch in this PR), and none from code in the30-monitorsservice.What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)