Skip to content

Fix deprecation warnings in monitors service - #1805

Merged
annamontare-nava merged 2 commits into
masterfrom
anna/fix-deprecation-warnings-in-monitors-service
Nov 16, 2026
Merged

annamontare-nava merged 2 commits into
masterfrom
anna/fix-deprecation-warnings-in-monitors-service

Conversation

@annamontare-nava

Copy link
Copy Markdown
Contributor

JIRA Ticket:
n/a

What Does This PR Do?

This PR fixes deprecation warnings in the output of tofu actions on the monitors service.
It does this by only selecting the attributes of objects that are actually used, since otherwise tofu will give errors.
Note that we weren't actually using the deprecated attributes, tofu just sees them as part of an object we create and complains.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Any other errors to fix?

Validation

  • Run tofu plan on each environment for the 30-monitors service. You should see only two deprecation warnings from the platform module (which I did not touch in this PR), and none from code in the 30-monitors service.
  • See also that the plan does not change any resources (this change should have no functional effect).

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@ryan-morosa ryan-morosa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation worked as described! Had to do some initial set up since I haven't used tofu much but I don't see the deprecation warnings anymore. Even saw the difference when looking at it on master too.

@annamontare-nava
annamontare-nava merged commit 7c2486c into master Nov 16, 2026
17 checks passed
@annamontare-nava
annamontare-nava deleted the anna/fix-deprecation-warnings-in-monitors-service branch November 16, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants