Repository navigation
Validate client secret empty case - #1801
Merged
ryan-morosa merged 11 commits intoNov 17, 2026
Merged
Conversation
ryan-morosa
marked this pull request as ready for review
November 14, 2026 00:11
BenColeCode
self-requested a review
November 16, 2026 14:40
BenColeCode
reviewed
Nov 16, 2026
BenColeCode
left a comment
Contributor
There was a problem hiding this comment.
Tests pass. besides my one question about where to initialize Client(), looks good to me, and I will approve after.
BenColeCode
previously approved these changes
Nov 16, 2026
BenColeCode
left a comment
Contributor
There was a problem hiding this comment.
Looks good from my end.
bwang-icf
reviewed
Nov 17, 2026
ryan-morosa
deleted the
ryan-morosa/bb2-5341-client-sec-empty-bug-fix
branch
November 17, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-5341
What Does This PR Do?
This PR validates that a client secret cannot be empty for symmetric authentication within the token endpoint. It looks at both the header and the post body. Ensures any mismatch between the post body and header fails validation as well.
Summary Of Changes:
What Should Reviewers Watch For?
validate_app_is_activesection since the authorize endpoint uses that as well.If you're reviewing this PR, please check for these things in particular:
Validation
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)