Repository navigation
Fix for 25.7 and disable gpu in benchmarks on mac - #15
Merged
Merged
Conversation
bgreni
force-pushed
the
disable-mac-gpu
branch
2 times, most recently
from
October 14, 2025 18:33
9cade2e to
664301e
Compare
Signed-off-by: Brian Grenier <grenierb96@gmail.com>
bgreni
force-pushed
the
disable-mac-gpu
branch
from
October 24, 2025 22:58
664301e to
ae5b6d8
Compare
BradLarson
approved these changes
Oct 31, 2025
BradLarson
left a comment
BradLarson
left a comment
Owner
There was a problem hiding this comment.
Nice! Thanks for the added formatting task, I was doing that manually via ruff.
Hopefully won't have to have the Apple silicon graphs disabled for too much longer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally this included disabling the benchmarks on mac because they couldn't compile, but in the latest nightly they all seem to work now!
Also added a format task as I see that is now a part of the CI