feat(enterprise): support governance_reports endpoints#258
Merged
Conversation
BoxBoxJason
added
enhancement
There was a problem hiding this comment.
Pull request overview
Adds a new GovernanceReportsService to the Go SDK to support SonarQube Enterprise governance report endpoints, wiring it into Client and providing unit + (placeholder) integration tests.
Changes:
- Added
sonar/governance_reports_service.gowith methods for download/status/subscribe/unsubscribe/update_frequency/update_recipients. - Added mock-based unit tests for the new service.
- Registered the new service on
sonar.Clientand added an integration test suite stub.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| sonar/governance_reports_service.go | Implements the governance reports service methods and option/response types. |
| sonar/governance_reports_service_test.go | Adds unit tests for the new governance reports service. |
| sonar/client.go | Registers the new service on the client (and also adds an unexpected SecurityReports registration). |
| integration_testing/governance_reports_test.go | Adds placeholder e2e coverage for the new service. |
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
BoxBoxJason
force-pushed
the
feat/enterprise-governance-reports-endpoints
branch
from
76f45d1 to
a803145
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the new "GovernanceReports" Service to interact with the enterprise Governance reports endpoints.
Packaged with full mock api response unit tests
e2e tests are dummies for now.
Closes #211
I have:
How has this code been tested
I have:
make lintpasses to verify that the code style is correct.make testpasses to verify that the code is working as intended.make e2epasses to verify that end-to-end tests pass against a real SonarQube instance.