Conversation
Now a loop of repos will continue on error. Signed-off-by: Jim Fitzpatrick <jfitzpat@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
Summary
std.process.exit(1)calls inside the repo-processing loop with error returns so that a failure on one repo does not abort the restrun_failureflag to track whether any repo failed during processingAcceptance Criteria
The issue states: "When cloning a list of repos if one is existing the error causes the whole process to stop. This should not be the case. It should report the error but it should also continue to and process the rest of the list."
clone(),worktree(), andaddRemote()helper functions now return errors instead of callingstd.process.exit(1), allowing the main loop to catch failures and continue to the next reporun_failureflag accumulates failure state across all repos, andstd.process.exit(1)is called only after all repos have been attempted