Build: Add Support of cover image for pages and also grid view for list of pages (#21)#6115
Closed
brij-mandaliya wants to merge 2 commits intoBookStackApp:developmentfrom
Closed
Build: Add Support of cover image for pages and also grid view for list of pages (#21)#6115brij-mandaliya wants to merge 2 commits intoBookStackApp:developmentfrom
brij-mandaliya wants to merge 2 commits intoBookStackApp:developmentfrom
Conversation
…st of pages (#21) * Buid: Cover image for pages and also add grid view for list of pages in chapter show page with test case and update create test case for page and add two test case one for update cover image for page and another for reset cover image for page * fix: lint php * set to get default page cover image from env * fix: lint php * feat(pages): add image_id support and update cover handling. - Added `image_id` field to `entity_page_data` model and migration - Updated `PageQueries` to select `image_id` and reference entity_page_data columns explicitly - Modified `PageRepo` to handle cover image updates consistently for drafts and revisions - Extended `EntityCover` and `EntityHtmlDescription` to support `Page` entities - Adjusted `BookContents` queries to use entity_page_data.draft - Updated Blade views to use `coverInfo()->getUrl()` for page list items - Introduced sidebar view-toggle for pages in chapter actions - Removed `ContainerTrait` from `Page` and replaced defaultTemplate with descriptionInfo * fix the link. * fix link * refactor(entities): migrate draft and cover image handling to entity_container_data table - Move draft status from entities table to entity_container_data table - Add fillable fields to EntityContainerData for image_id, sort_rule_id, and description fields - Update all draft queries to use entity_page_data.draft join condition - Enhance ReferenceChangeContext to track URL and permalink mappings during cloning - Update ReferenceUpdater to process reference changes in descriptions and page content - Modify cover image access to use coverInfo() method instead of cover property - Fix entity-list-item class naming from chapter to page - Update copy tests to verify reference updating during entity cloning BREAKING CHANGE: Draft status is now stored in entity_container_data table instead of entities table * fix lint * fix analysis
Member
|
Thanks for offering this PR @brij-mandaliya, but there are too many different changes here, and I'm not confident I'd look to included the mentioned features at this time. Therefore I'm going to close this off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buid: Cover image for pages and also add grid view for list of pages in chapter show page with test case and update create test case for page and add two test case one for update cover image for page and another for reset cover image for page
feat(pages): add image_id support and update cover handling.
image_idfield toentity_page_datamodel and migrationPageQueriesto selectimage_idand reference entity_page_data columns explicitlyPageRepoto handle cover image updates consistently for drafts and revisionsEntityCoverandEntityHtmlDescriptionto supportPageentitiesBookContentsqueries to use entity_page_data.draftcoverInfo()->getUrl()for page list itemsContainerTraitfromPageand replaced defaultTemplate with descriptionInfoBREAKING CHANGE: Draft status is now stored in entity_container_data table instead of entities table
Details
Checklist