Feat/device discovery#250
Merged
Merged
Conversation
When updating the system for the first time, the configurator will sync the config repo with the printer config directory, but it will create rescursive nested config dirs, the problem has two parts, first, the rescursiveness only happens when there is an update, and the repo/printer config are out of sync, the second is because of the legacy configurations. We now clean the previous printer config repo dirs, before actually symlinking the repo with the printer configurations. This is only part of the fix. The second part of this commit, adds the second sync mode to the tool, but it will not be used right now, this is prepign for future work.
Co-authored-by: Guilherme Costa <guilherme.costa@blockstec.com> Signed-off-by: Hugo Costa <hugo.santos.costa@gmail.com>
There was a problem with printer.cfg merging, everytime merging occured two things happened, first was that the beacon section on pritner.cfg was not ignored, this made the configured serial path to be lost, the second problem was that the saved configuration (footer) was duplicated everytime, so if the screen restarted we whould have thounsands of lines duplicated. With this fix, both issues are resolved. Another quality of life is that, the deletetion of the printer configurations subdirectories is not done unless there is actually something different between the config repo and the printers config dir.
…figurator-saved-duplication
…marker There were a bunch of problems that would make merging files difficult, one of those was the merger or configparser sections, the default is to use = but the code was using : to set values to options. Then there was a problem when checking nestes config dirs on the default configuration directory. This looks like it has been solved as well.
…on' into feat/device-discovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Printer configurations require the serial path of hardware devices, as is the case for beacon probe. This pull request finds the serial path of such devices and adds it to the configuration file
printer.cfg.This is the first effort on creating an automatic detector of hardware on the machine, future work will include recon for CAN devices, USB cameras etc, the storage module will also be refacored to create a single use tool which will be mainly done in cpp.