perfomance(blocks_button): remove recursive and redudant paint call in paintevent#246
Merged
Conversation
gmmcosta15
added
enhancement
HugoCLSC
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
This change introduces a major fix in the
paintEvent()implementation ofblocks_button.Previously,
paintEvent()calledsetStyle(), which internally triggered anupdate(). This resulted in a recursive repaint cycle wherepaintEvent()indirectly caused additionalpaintEvent()calls through unnecessaryupdate()requests.By removing the
setStyle()call frompaintEvent(), these redundant updates are eliminated, significantly improving performance on Raspberry Pi devices.Performance improvements observed:
CPUusage reduced from approximately 40% to 2%.GILusage reduced from approximately 73% to below 10%.Active Threadusage reduced from approximately 90% to 7%.Motivation
The application was consistently consuming nearly an entire CPU core while idle.
After a careful investigation, the root cause was identified as the recursive repaint/update behavior in
blocks_button. Removing the unnecessarysetStyle()call frompaintEvent()eliminates the excessive repaint requests, resulting in a drastic reduction in CPU usage and significantly improved idle performance.