Skip to content

Support authenticated NuGet downloads on Windows - #1148

Open
sathyarajagopal wants to merge 1 commit into
Blizzard:masterfrom
sathyarajagopal:fix/windows-nuget-auth
Open

sathyarajagopal wants to merge 1 commit into
Blizzard:masterfrom
sathyarajagopal:fix/windows-nuget-auth

Conversation

@sathyarajagopal

Copy link
Copy Markdown

Summary

  • allow Windows NuGet downloads to include configurable HTTP headers
  • support Basic, Bearer, API-key, access-token, and custom authentication
  • document NODE_RDKAFKA_NUGET_HEADERS
  • add unit tests for authenticated and unauthenticated requests

Testing

  • python3 deps/windows-install.spec.py (4 tests passed)
  • python3 -m py_compile deps/windows-install.py deps/windows-install.spec.py
  • git diff --check

The full project test and lint targets could not be run locally because project dependencies are not installed and the existing Makefile requires Python 2.

Allow private NuGet repositories to provide request headers.

Document supported auth schemes and add request construction tests.
@sathyarajagopal

sathyarajagopal commented Aug 3, 2026

Copy link
Copy Markdown
Author

@GaryWilber @edenhill @webmakersteve Could you please review this and help push this through?

For context, our company policy blocks external downloads, so all artifacts must be retrieved through our internal JFrog Artifactory. Because this internal repository requires authentication, unauthenticated requests are rejected.
When running "npm install node-rdkafka" with a custom NODE_RDKAFKA_NUGET_BASE_URL, the librdkafka.redist download failed because the current urllib.urlopen call does not include authentication headers. This PR adds support for configurable request headers, enabling downloads from authenticated private repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant