fix(wasm-utxo): skip empty bip32Derivation when resolving PSBT input descriptors#285
Merged
veetragjain merged 1 commit intoMay 27, 2026
Conversation
OttoAllmendinger
requested changes
May 26, 2026
| function getDerivationPaths(v: WithBip32Derivation | WithTapBip32Derivation): string[] | undefined { | ||
| if ("bip32Derivation" in v && v.bip32Derivation) { | ||
| return v.bip32Derivation.map((v) => v.path); | ||
| if (!Array.isArray(v.bip32Derivation) || v.bip32Derivation.length > 0) { |
Contributor
There was a problem hiding this comment.
why !Array.isArray here?
wouldn't extending the conditional with && v.bip32Derivation.length > 0 in the preceding line do it?
Contributor
Author
There was a problem hiding this comment.
Was working with js files and did not see a type there so added array check there and copied the change here. We already have type checks here, so adding the Array check does not help. Changed the condition.
veetragjain
force-pushed
the
veetragjain/cshld-909-add-client-side-verification-for-reclaim-transaction
branch
from
1e3cff3 to
f19106a
Compare
OttoAllmendinger
approved these changes
May 27, 2026
veetragjain
deleted the
veetragjain/cshld-909-add-client-side-verification-for-reclaim-transaction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty bip32Derivation arrays are truthy in JavaScript, so getDerivationPaths
previously returned no paths instead of checking tapBip32Derivation. Skip empty
derivation arrays and continue to the next source.