Repository navigation
Opened by mistake, please disregard - #500
Closed
markomanka wants to merge 1 commit into
Closed
markomanka wants to merge 1 commit into
markomanka wants to merge 1 commit into
Conversation
- core/util/log.h: self-contained logger. Same output format as ROOT
("<Level> in <location>: message") and the same numeric levels
(kLogPrint..kLogFatal equal ROOT's kPrint..kFatal), so verbosity settings
keep their meaning. Thread-safe; flushes stdout before writing to stderr.
- core/util/math.h: kPi without TMath. NormalPdf and PoissonPdf replace
ROOT::Math::normal_pdf and poisson_pdf (max relative difference 5.7e-14
over the tested range). PoissonPdf returns 0 for x < 0, where the ROOT
call converted a negative value to unsigned (undefined behaviour).
- substance_initializers.h, model_initializer.h, multi_simulation/experiment.h:
use the new helpers and std::accumulate.
- neuroscience: five direct calls to ROOT's global Fatal() now use
Log::Fatal(), which prints "Error in <...>" and exits with code 1
instead of aborting.
- param/command_line_options.cc: verbosity drives Log::SetLevel and, while
ROOT is still linked, gErrorIgnoreLevel for ROOT's own messages.
- CMake: option BDM_ANY_PYTHON accepts any Python >= 3.9 when ROOT does not
come from the pinned prebuilt bundle (default OFF: current behaviour).
Verified against conda-forge ROOT 6.40.04 with GCC 15.3.0: all 61 library and
68 unit-test sources compile; log output is byte-identical to ROOT's.
Full link and test run: BioDynaMo CI.
Contributor
Author
|
Opened against the upstream repository by mistake, while testing changes in my fork. Please disregard; sorry for the noise. |
markomanka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.