Repository navigation
Breaking: unify route destinations and BPRoute controls for v11 - #116
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 192 files, which is 42 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. This review is too large to run within your organization's remaining usage spending cap. Raise or remove your spending cap in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (192)
You can disable this status message by setting the
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 177c9e4fa6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdb07769b8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
@codex review |
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aecf492032
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3232d0de9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a668de4b07
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
Merged with the configured bcbetterninja signing key and released as v11.0.0. All PR/master CI and the release workflow passed; all 14 public Node packages are verified at latest=11.0.0. The eight BetterPortal easy1 services were rebuilt and deployed: seven public manifest/health probes pass at 11.0.0 (three samples each), the private registry logs confirm v11.0.0, and all 16 expected app replicas run. Source/settings verification passed. Custom trg-one themes bundling the shared runtime still need their own rebuild/redeployment as documented. Python publishing PR #105 stays deferred. CodeRabbit skipped this large PR due its file/usage limit; the Codex review loop completed and every finding was fixed and resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service-rendered links repeatedly selected mounted UI paths instead of service destinations, and older shell metadata left
/batches/1anchors without the HTMX request or mounted prefix. This breaking change makesBPRoutethe normal JSX interface andctx.route()the explicit destination resolver, then fixes service-owned link mapping in the shared theme runtime.routeUrl,uiRouteUrl, rendererctx.url,routeUiattribute helpers andBPElement; old usage fails types/authoring/ESLint. Move renderer metadata torouteInfo.Validation: complete Node workspace suite and lint pass; 199 framework tests (including the additional review path-classification regression) and 56 shared-runtime tests cover actual JSX state overrides, UUID mounting/history, service/UI collisions and failed DELETE fallback isolation. Full HTTP interoperability passed 7,050/7,050 cases. Rebuilt native generators, positive/negative compiler checks and executable documentation pass. Review fixes include Python service-fragment shell composition, canonical nullable C# route args and linear handler path classification for the CodeQL finding. Additional review regressions cover browser caller policy (including platform-root), precise JSX lint locations and actual Node-hosted shell fragment insertion. Final edge-case regressions cover swap-only controls in Chromium, native target/swap aliases and OPTIONS rejection. GitHub checks must pass before merge.