Add support for option number-format of fn:parse-json#2676
Merged
Conversation
Member
|
…perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support for option
number-formattofn:parse-jsonfn:json-docjson:parseIt replaces option
number-parserfor these functions.number-parsercontinues to be supported forfn:json-to-xml.All of these options are defined in
JsonParserOptions, though the allowances are different for different functions (this was even the case before these changes with optionnull). Upon invocation, there is an extra check for the option being supported with the particular format, but as it is now, it can only trigger an error upon non-default-values.There are 14 QT4 test cases using
number-parserforfn:parse-jsonandfn:json-doc, which are now failing becausenumber-parseris rejected.