Repository navigation
fix(ui): render the clarify card again - #303
Merged
Merged
Conversation
clarify.js assigned input.type='text' on a <textarea>. HTMLTextAreaElement.type is a readonly accessor, so the strict-mode module threw before the card was inserted and the agent's question never appeared in the WebUI. Drop the assignment. The DOM shim now models the readonly getter so the regression fails every render test, and new tests cover the countdown and expiry, undelivered answers, duplicate-submit guard, decision recording, card replacement, supervision exposure and stop-work (clarify.js line coverage 94.9% -> 100%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 691cd7d | Commit Preview URL Branch Preview URL |
Oct 08 2026, 05:04 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The WebUI clarify card never appeared.
clarify.jssetinput.type = 'text'on a<textarea>;HTMLTextAreaElement.typeis a readonly accessor, so the strict-mode module threwTypeErrorinsiderenderCardbefore the card was inserted into the DOM.Fix
Remove the assignment. No other textarea
.typewrites exist in the UI (the remainingtype='text'sites are<input>elements).Tests
textarea.typeas a getter-only property, matching browsers. With the oldclarify.js, all clarify tests fail; with the fix they pass.clarify.jsline coverage: 94.9% → 100% (branches 69% → 89%).node --test "cmd/odek/ui/js/**/*.test.js": 263/263 pass.🤖 Generated with Claude Code