Skip to content

fix: correct prompt admission, usage accounting and runtime state - #282

Merged
jkyberneees merged 1 commit into
mainfrom
fix/functional-runtime-regressions
Sep 30, 2026
Merged

jkyberneees merged 1 commit into
mainfrom
fix/functional-runtime-regressions

Conversation

@jkyberneees

Copy link
Copy Markdown
Contributor

Attachment-only prompts were discarded, failed turns omitted paid token usage, model switches retained stale cost prices, and long-running scheduled jobs could overwrite newer scheduling state.

This change fixes all five confirmed functional regressions:

  • Accept usable attachments without prompt text in WebSocket and REST requests, and reject empty placeholders before starting a turn.
  • Resolve uploaded attachments against the effective current session when the request omits its session ID.
  • Record provider usage for failed turns in sessions, server totals, and REST run snapshots.
  • Re-resolve model cost prices from the original configuration when switching models, including fallback prices.
  • Serialize scheduler projection/completion persistence, retain the current next-run time and cron signature, and avoid recreating state for removed jobs.

Validation: full changed-package race tests; targeted race tests covering the final amendments; golangci-lint v2.14.0; go vet; govulncheck. All passed. An independent adversarial sub-agent review found two gaps in the initial patch; both were fixed and regression-tested, and the final re-review found no remaining actionable issues.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
odek 88f397a Commit Preview URL

Branch Preview URL
Sep 30 2026, 07:28 AM

@jkyberneees
jkyberneees merged commit e1e1233 into main Sep 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant