Repository navigation
fix(tui): keep cancel latch, sanitize @-refs, collapse notices - #87
Merged
Merged
Conversation
Approval expiry and answer dropped the cancelling latch so Enter re-queued restored drafts. @-completion painted and inserted raw resource fields. Engine notices kept newlines from the wire. Co-authored-by: admin <admin@21no.de>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bodek | 801a165 | Commit Preview URL Branch Preview URL |
Sep 05 2026, 08:13 PM |
jkyberneees
marked this pull request as ready for review
September 5, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Seventh self-improvement pass after v1.4.6. Three bugs, RED-first, reviewer-validated.
Approval expiry and answer dropped the cancelling latch. v1.4.6 gated thinking/token/tool_call via
setRunStatus, butanswer()andhandleApprovalExpirystill assignedthinking/approval requireddirectly. After cancel restored the queue into the composer, expiry or deny let Enter re-queue the draft. Those paths (plusapproval_requestandapprovalSendErrMsg) now usesetRunStatus.@completion painted and inserted raw/api/resourcesfields. Label/Detail leaked CSI into the popup; ID was spliced into the composer. Collapse at ingest, paint, and insert.Engine notices kept raw newlines.
--plainalreadycollapses skill/memory/signal; the alt-screen strip usedsanitize(CSI gone, newlines kept), so a wireSkillNamelike"x\n● disconnected"painted a second chrome-like row.addTransientNotenow collapses.Tests
TestCancelApprovalDoesNotClobberCancelling(expiry / deny)TestResourceCompletionSanitizesWireFieldsTestEngineNoticesCollapseNewlinesmake fmt/vet/lint0 issues.make testrace green.Expert review: APPROVE.