Repository navigation
fix(tui): show bare tool results, extract parallel results arrays - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tool-result peeks now show only the tool result:
⚠ untrusted: <source>badge line is gone; the wrapped body renders bare (sanitize() still runs; provenance framing survives via the⎿peek under the tool head).parallel_shell/delegate_tasksreturn a top-levelresultsarray; each item now renders its display body (stdout → content/result/output/text → headline priority), a leadingexit status Nline when the item failed, andstderr: …when present. Command echoes, indexes, and durations stay hidden. Items are labelled[1] [2] …only when there are several.exit_codeanywhere in the envelope flags the step (hasFailedExitOR-ed intoisErr), so it tints red and auto-expands even when the stdout looks innocuous.Review findings addressed (2 adversarial reviewers, iterate-until-clean)
{"content":…}envelope no longer renders mangled half-JSON).hasFailedExit+ leadingexit status N(both reviewers flagged this).int(f)truncation (wire sends integers), receipt-heuristic misfires (pre-existing class).Test plan
hasFailedExitgo test -race -count=1 ./...greengo vet ./...clean ·golangci-lint run→ 0 issues