Prioritize deployment environment set in OTEL_RESOURCE_ATTRIBUTES#3405
Open
scottrudy wants to merge 6 commits into
Open
Prioritize deployment environment set in OTEL_RESOURCE_ATTRIBUTES#3405scottrudy wants to merge 6 commits into
scottrudy wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the isolated worker OpenTelemetry FunctionsResourceDetector so that deployment.environment.name is not overwritten when a higher-priority value is already provided via OTEL_RESOURCE_ATTRIBUTES, aligning behavior with the intended priority order in Azure environments.
Changes:
- Skip adding
deployment.environment.namefromWEBSITE_SLOT_NAMEwhenOTEL_RESOURCE_ATTRIBUTEScontainsdeployment.environment.nameordeployment.environment. - Add a semantic convention constant for
deployment.environmentto support the new priority check. - Add/adjust tests and update OpenTelemetry package release notes for the behavior change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/DotNetWorker.OpenTelemetry.Tests/EndToEndTests.cs | Adds test coverage for skipping deployment.environment.name when configured via OTEL_RESOURCE_ATTRIBUTES (currently contains issues). |
| src/DotNetWorker.OpenTelemetry/ResourceSemanticConventions.cs | Adds deployment.environment constant to support priority checking. |
| src/DotNetWorker.OpenTelemetry/release_notes.md | Documents the updated detector behavior and references #3404. |
| src/DotNetWorker.OpenTelemetry/FunctionsResourceDetector.cs | Implements the priority/skip logic for deployment environment attributes (Azure-only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jviau
reviewed
May 8, 2026
RohitRanjanMS
requested changes
May 19, 2026
| { | ||
| attributes.Add(new(ResourceSemanticConventions.DeploymentEnvironmentName, slot)); | ||
| attributes.Add(new(ResourceSemanticConventions.DeploymentEnvironmentName, slot)); |
| public static IEnumerable<object[]> EnvironmentNameSkippedData => | ||
| [ | ||
| // OTEL_RESOURCE_ATTRIBUTES[deployment.environment.name] set in Azure | ||
| [new Dictionary<string, string> { { "WEBSITE_SITE_NAME", "appName" }, { "WEBSITE_SLOT_NAME", "staging" }, { "OTEL_RESOURCE_ATTRIBUTES", "deployment.environment.name=custom-name,other.key=value" } }], |
Member
There was a problem hiding this comment.
Add tests for deployment.environment.name and deployment.environment with empty values. If a user accidentally sets an empty value, the slot name gets silently skipped.
Author
There was a problem hiding this comment.
Good call out. Explicit tests have been added.
Member
|
@scottrudy, thanks for putting in the time to create this PR. Really appreciate you doing it. |
… detector when set in OTEL_RESOURCE_ATTRIBUTES
scottrudy
force-pushed
the
scottrudy/stop-otel-env-override
branch
from
516597c to
c828b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further enhances the isolated worker's FunctionsResourceDetector and the changes made in #3362.
FunctionsResourceDetector
The attribute deployment.environment.name now follows priority order (Azure only):
WEBSITE_SLOT_NAME.
Issue describing the changes in this PR
resolves #3404
Pull request checklist
release_notes.md