[#4721] Allow EventProcessorDefinitions to supply an event source for a subscribing processor#4722
Merged
hatzlj merged 3 commits intoJul 8, 2026
Conversation
hatzlj
requested review from
MateuszNaKodach,
jangalinski and
zambrovski
and removed request for
a team
hatzlj
added
Type: Enhancement
hatzlj
force-pushed
the
enhancement/4721/subscribing-processors-source-config-improvement
branch
from
e1b5dd7 to
7c4fe71
Compare
laura-devriendt-lemon
approved these changes
Jul 8, 2026
laura-devriendt-lemon
left a comment
laura-devriendt-lemon
left a comment
Contributor
There was a problem hiding this comment.
just suggestion
smcvb
approved these changes
Jul 8, 2026
smcvb
left a comment
smcvb
left a comment
Contributor
There was a problem hiding this comment.
One nit, otherwise looks good to me.
…ProcessorSettings#source()` is explicitly set To allow subsequent customizations supply a `SubscribablEventSource`, the SpringCustomizations.SpringSubscribingEventProcessingModuleCustomization is adjusted so that the source is only mandatory if a name is explicitly set via the `EventProcessorSettings#source()`. Now, if the `EventProcessorSettings#source()` is not set or empty, the message source is only applied if resolvable from the config (i.e. if a type level source like the `EventBus` is configured), but no exception is thrown as before. If the `EventProcessorSettings#source()` is explicitly set, the behaviour stays as before that a `SubscribablEventSource` with that exact name must be resolvable from the configuration, otherwise an exception is thrown.
…validation To make debugging easier, include the event processor name in the validation exception thrown if the event source is not set in a SubscribingEventProcessorConfiguration.
…upplied event sources Cover the case when an explicitly configured event source should be supplied via an EventProcessorDefinition instead of failing in the SpringCustomization due to the type-based Event Source not being unique.
hatzlj
force-pushed
the
enhancement/4721/subscribing-processors-source-config-improvement
branch
from
7c4fe71 to
1ca5742
Compare
hatzlj
deleted the
enhancement/4721/subscribing-processors-source-config-improvement
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the SpringCustomizations.SpringSubscribingEventProcessingModuleCustomization to allow subsequent customizations to supply a
SubscribableEventSourceby making the source only mandatory if a name is explicitly set via theEventProcessorSettings#source().Now, if the
EventProcessorSettings#source()is not set or empty, the message source is only applied if resolvable from the config (i.e. if a type level source like theEventBusis configured), but no exception is thrown as before.If the
EventProcessorSettings#source()is explicitly set, the behaviour stays as before that aSubscribablEventSourcewith that exact name must be resolvable from the configuration, otherwise an exception is thrown.Resolves #4721