fix(mpris): enrich metadata across equivalent players#2928
Open
arqueon wants to merge 1 commit into
Open
Conversation
arqueon
marked this pull request as ready for review
July 24, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrackArtServiceborrow artwork from an equivalent MPRIS sourceWhy
Browsers and desktop integrations can expose multiple MPRIS players for the same playback. One source may provide working transport controls but incomplete metadata, while another exposes the artist, album, or artwork. Selecting only the first playing entry leaves the native DMS media UI with missing information.
The fix is provider-agnostic: it operates only on MPRIS state and capabilities and adds no site-specific lookup or scraping.
Impact
DMS remains the owner of player selection and transport. The native media surfaces and any plugin consuming
MprisControllerorTrackArtServicecan use richer metadata without switching control to a read-only mirror. Single-source players keep their existing behavior.Validation
qmllintpassed for all three changed QML filesTrackArtService.artReadyFor()returnedtrue