Skip to content

fix: Dart dependency graphs and cross-language caller isolation - #492

Merged
rs545837 merged 4 commits into
mainfrom
fix/dart-graph-491
Sep 22, 2026
Merged

rs545837 merged 4 commits into
mainfrom
fix/dart-graph-491

Conversation

@rs545837

@rs545837 rs545837 commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes #491.

  • Resolve real Dart call expressions, declaration scopes, constructor-bound locals and typed parameters, including new/const construction.
  • Filter typed/static member candidates by language family; prefer imported/local class owners. Preserve JS/TS interoperability.
  • Invalidate persisted graph/query caches so upgrades do not retain the old edges.
  • Add eight core regression tests and cold/warm CLI callers/refs coverage. Replace the old test that expected zero Dart call edges.

Validation

  • Local core/CLI unit and integration suites: 1,115 passing tests across 44 suites.
  • Final Dart fixture rerun: all eight tests pass.
  • Core doc-test target passes (zero doctests).
  • Tests ran with GIT_CONFIG_GLOBAL=/dev/null and GIT_CONFIG_NOSYSTEM=1 to prevent the locally configured external Git diff wrapper from corrupting patch-input fixtures. No machine settings changed.
  • CI is pending; merge is gated on the latest head and passing checks.

Boundaries

This fixes the reported extraction and mixed-language collision bugs, not complete Dart semantic resolution. Dart import aliases, package URIs, dynamic dispatch and incremental resolution reuse require separate work. Dart remains conservatively ineligible for incremental edge reuse.

@inspect-review inspect-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 25 entities analyzed | 0 critical, 0 high, 9 medium, 16 low
Verdict: standard_review

Findings (0)


Reviewed by inspect | Entity-level triage found 0 high-risk changes

@rs545837
rs545837 marked this pull request as ready for review September 22, 2026 15:48
@rs545837

Copy link
Copy Markdown
Member Author

Temporarily reopening to refresh a stale PR head: the branch points to 1a9686a, while the PR ref is still f5da7ed. The latest commits include the required changelog entry and a fixture correction. No merge until checks cover the current head.

@rs545837 rs545837 closed this Sep 22, 2026
@rs545837 rs545837 reopened this Sep 22, 2026

@inspect-review inspect-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 25 entities analyzed | 0 critical, 0 high, 9 medium, 16 low
Verdict: standard_review

Findings (0)


Reviewed by inspect | Entity-level triage found 0 high-risk changes

@inspect-review inspect-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 25 entities analyzed | 0 critical, 0 high, 9 medium, 16 low
Verdict: standard_review

Findings (0)


Reviewed by inspect | Entity-level triage found 0 high-risk changes

@rs545837

Copy link
Copy Markdown
Member Author

Refreshing the stale PR head after the final explicit-this regression fix. Final local validation: 1,115 core/CLI tests pass, including eight focused core regressions and cold/warm CLI coverage. The branch is now 2c427f2; CI must evaluate that head.

@rs545837 rs545837 closed this Sep 22, 2026
@rs545837 rs545837 reopened this Sep 22, 2026

@inspect-review inspect-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 26 entities analyzed | 0 critical, 0 high, 9 medium, 17 low
Verdict: standard_review

Findings (0)


Reviewed by inspect | Entity-level triage found 0 high-risk changes

@inspect-review inspect-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect review

Triage: 26 entities analyzed | 0 critical, 0 high, 9 medium, 17 low
Verdict: standard_review

Findings (0)


Reviewed by inspect | Entity-level triage found 0 high-risk changes

@rs545837
rs545837 merged commit d088320 into main Sep 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dart: entities parse but the dependency graph has zero edges (impact/callers/refs silently empty)

1 participant