Repository navigation
fix(panel): disable editor buttons while busy; surface action failures inline - #12
Merged
Merged
Conversation
…s inline - Save/Cancel now respect the shared busy flag — double-clicking Save can no longer fire two write POSTs - act() catches network-level failures instead of leaving an unhandled rejection; non-2xx and fetch errors surface inline via the previously unused saveFailed/deleteFailed locale keys Fixes AskTheWay#8
AskTheWay
approved these changes
Oct 5, 2026
AskTheWay
left a comment
AskTheWay
left a comment
Owner
There was a problem hiding this comment.
Reviewed as maintainer: diff matches the linked issue; verified the three PRs combined on top of main locally — 92/92 tests + tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
What
busyflag (row buttons already did) — double-clicking Save can no longer fire two write POSTs.act()wraps the action in try/catch: network-level failures no longer become unhandled rejections, and both fetch errors and non-2xx responses surface inline next to the Refresh button using thesaveFailed/deleteFailedlocale keys (which existed but were never referenced).Client-half only; no API or store changes. 92/92 tests + tsc clean locally.
CONTRIBUTING checklist: no new write path; no session events; baseline-module imports only (no new imports at all).