fix(consensus): correct locked and valid value handling across rounds and restarts - #1450
Open
oXtxNt9U wants to merge 7 commits into
Open
fix(consensus): correct locked and valid value handling across rounds and restarts#1450oXtxNt9U wants to merge 7 commits into
oXtxNt9U wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1450 +/- ##
===========================================
+ Coverage 77.57% 77.96% +0.39%
===========================================
Files 923 934 +11
Lines 16019 16463 +444
Branches 2205 2286 +81
===========================================
+ Hits 12426 12835 +409
- Misses 3588 3621 +33
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oXtxNt9U
force-pushed
the
fix/consensus/prevote-nil-when-locked
branch
from
August 17, 2026 04:03
897f433 to
53747e3
Compare
oXtxNt9U
force-pushed
the
fix/consensus/prevote-nil-when-locked
branch
from
August 17, 2026 05:39
59ec00f to
1bb461e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onProposalprevoted any valid proposal regardless of the lock, so a validator locked on one block could help a conflicting one reach +2/3 in a later round#signProposalre-proposed a restored valid value without deserializing its payload, throwing into an unawaited promise and killing the node on startuponProposalLockedprevoted nil for a lock-proven proposal whenever the proposer'svalidRoundpredated the lock even when the proposal was for the very block the validator was locked on, wasting a round each timeChecklist