Skip to content

fix(consensus): prevent double signing after a crash or restart - #1449

Merged
oXtxNt9U merged 6 commits into
developfrom
fix/consensus/double-sign-guard
Aug 14, 2026
Merged

fix(consensus): prevent double signing after a crash or restart#1449
oXtxNt9U merged 6 commits into
developfrom
fix/consensus/double-sign-guard

Conversation

@oXtxNt9U

Copy link
Copy Markdown
Contributor

Summary

  • Validators now durably record the last signed position (blockNumber/round/step + value)
  • After a restart signing a conflicting message at or below the recorded position throws DoubleSignError instead
  • The proposal/prevote/precommit is skipped with a warning and the validator resumes at the next round/height on its own

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.76%. Comparing base (87365ff) to head (e234065).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1449      +/-   ##
===========================================
+ Coverage    77.34%   77.76%   +0.41%     
===========================================
  Files          922      934      +12     
  Lines        15954    16415     +461     
  Branches      2167     2260      +93     
===========================================
+ Hits         12340    12765     +425     
- Misses        3609     3643      +34     
- Partials         5        7       +2     
Flag Coverage Δ
contracts 91.76% <ø> (?)
packages 77.38% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U
oXtxNt9U merged commit b178403 into develop Aug 14, 2026
24 checks passed
@oXtxNt9U
oXtxNt9U deleted the fix/consensus/double-sign-guard branch August 14, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant