fix(p2p): request messages for an explicit block and round - #1444
Open
oXtxNt9U wants to merge 3 commits into
Open
fix(p2p): request messages for an explicit block and round#1444oXtxNt9U wants to merge 3 commits into
oXtxNt9U wants to merge 3 commits into
Conversation
- GetMessages requests now carry a mandatory (blockNumber, round, bitmaps) query - removes the timing races where honest replies were judged against a moved target and peers wrongly banned - precommit minorities now also trigger full downloads, matching the consensus rule - incomplete replies are logged instead of banned (not provable misbehavior) - payload limit scales with validator count
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1444 +/- ##
===========================================
- Coverage 77.34% 77.03% -0.32%
===========================================
Files 922 933 +11
Lines 15954 16656 +702
Branches 2167 2291 +124
===========================================
+ Hits 12340 12831 +491
- Misses 3609 3818 +209
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oXtxNt9U
marked this pull request as ready for review
August 10, 2026 04:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMessagesrequests now carry an explicit (blockNumber, round, bitmaps) query instead of the responder guessing from the request headers. The responder serves exactly the queried round or nothing.Checklist