Skip to content

fix(p2p): request the correct range when retrying a block download - #1443

Merged
oXtxNt9U merged 2 commits into
developfrom
fix/p2p/block-downloader-retry-range
Aug 7, 2026
Merged

fix(p2p): request the correct range when retrying a block download#1443
oXtxNt9U merged 2 commits into
developfrom
fix/p2p/block-downloader-retry-range

Conversation

@oXtxNt9U

@oXtxNt9U oXtxNt9U commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Retrying the only queued batch calculated the new range from the failed job's end instead of its start, requesting up to double the batch cap
  • Retries required the new peer to send the entire original range, rejecting peers that could serve the blocks still missing and stalling the download
  • The only pending batch may now shrink to what's still needed

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.73%. Comparing base (edacad6) to head (37c2fb3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1443      +/-   ##
===========================================
+ Coverage    77.33%   77.73%   +0.39%     
===========================================
  Files          922      933      +11     
  Lines        15952    16391     +439     
  Branches      2165     2242      +77     
===========================================
+ Hits         12337    12741     +404     
- Misses        3610     3643      +33     
- Partials         5        7       +2     
Flag Coverage Δ
contracts 91.76% <ø> (?)
packages 77.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U
oXtxNt9U merged commit 87365ff into develop Aug 7, 2026
24 checks passed
@oXtxNt9U
oXtxNt9U deleted the fix/p2p/block-downloader-retry-range branch August 7, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant