refactor(output): simplify FileStudyOutputs class#3243
Merged
Conversation
sylvlecl
reviewed
Jun 10, 2026
sylvlecl
left a comment
sylvlecl
left a comment
Member
There was a problem hiding this comment.
Looks good overall, just suggestions about naming and place of things
|
|
||
| def get_ui(self) -> DigestUI: | ||
| @staticmethod | ||
| def get_ui(file_path: Path) -> DigestUI: |
Member
There was a problem hiding this comment.
We could rename to "parse" something, to make it clear it parses the file.
Could be a free function in antarest.output.filestudy, too
Contributor
Author
There was a problem hiding this comment.
I renamed it parse_file_for_ui but kept it here just to centralize the logic
sylvlecl
requested changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.