feat(favorite_external_directory): add external directories favorite#3239
Open
mehdiwahada wants to merge 4 commits into
Open
feat(favorite_external_directory): add external directories favorite#3239mehdiwahada wants to merge 4 commits into
mehdiwahada wants to merge 4 commits into
Conversation
… of the FavoriteExternalDirectory class
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ? : Implements the addition of external directories as favorite
Why it has been done ? : The external directories don't have a stable id, so we need to add their path (workspace + current path) in the favorite handling API
How to test it ? : Try to add external directories with valid / invalid workspace or paths