Repository navigation
[cl] Redact credentials in task logs and uploaded artifacts - #247
Merged
Merged
Conversation
Build repository URLs carry the build system token and terraform TRACE logs can contain the OpenNebula password; both ended up in logs uploaded to Pulp. Mask URL credentials and known config secrets in command outputs, artifact files and task loggers, and hide repository URLs in the ansible repository tasks, including the Alpine one. (cherry picked from commit 498dcf1)
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #229 (498dcf1) from master to
cl.Build repository URLs carry the build system token and terraform TRACE logs can contain the OpenNebula password; both ended up in logs uploaded to Pulp. This masks URL credentials and known config secrets in command outputs, artifact files and task loggers, and hides repository URLs in the ansible repository tasks.
Differences from the master commit
alts/shared/utils/log_utils.py: merged with thecl-only helpers (get_temp_log_files,read_and_cleanup_temp_log_files,check_for_error_string).resources/roles/preparation/tasks/rhel.yml:no_log/loop_controlapplied tocl's "Add required repositories" task (the one with the Amazonpriority), which sits earlier in the file than on master.resources/roles/preparation/tasks/alpine.yml(cl-only): the APK repository task gets the sameno_log/loop_controltreatment.Testing
tests/shared/test_log_utils.py: 11 passed.alts/worker/runners/base.pyandalts/shared/models.py.🤖 Generated with Claude Code