Repository navigation
Don't retry test task on 4xx callback errors - #240
Merged
Merged
Conversation
A client error from callback_href (e.g. 404 for a removed build task) won't be fixed by re-running the whole test task, so log it instead of raising HTTPError into Celery autoretry. 5xx errors are still retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
callback_hrefreturns a 4xx (e.g. 404 for a removed build task),raise_for_status()raisedHTTPError, which is inAUTO_RETRY_EXCEPTIONS. Celery then re-ran the wholerun_teststask up to 5 more times (new environment, install, tests, teardown) for an error that retrying can't fix.Changes
alts/worker/tasks.py: on 4xx callback responses, log an error and return the summary instead of raising. 5xx responses still raise and are retried as before (502 is additionally retried at the HTTP level by the urllib3Retry).Testing
🤖 Generated with Claude Code