[PWGUD] Update FwdMuonsUPC#16307
Conversation
ariffero
commented
May 19, 2026
ariffero
commented
- Change V0A veto: veto only sel BC
- Remove histos and related configs
- Add checks on two-trakcs cand in FwdMuonsUPC
- Clean up of the task
|
O2 linter results: ❌ 3 errors, |
Please consider the following formatting changes to AliceO2Group#16307
Please consider the following formatting changes to AliceO2Group#16307
There was a problem hiding this comment.
Hi Andrea,
please, see this PR #15390 it seems you are reverting its changes. (usage of "" and <> in includes)
Also, please change the name of the file in a way that it does not start with a capital letter, so FwdMuonsUPC.cxx -> fwdMuonsUPC.cxx
Roman
Change "" to <> in include statements
Hi Roman, thanks for spotting that, I did not notice it before. Now it should be ok. |
Please consider the following formatting changes to AliceO2Group#16307
| /// \author Andrea Giovanni Riffero <andrea.giovanni.riffero@cern.ch> | ||
|
|
||
| #include "PWGUD/DataModel/UDTables.h" | ||
| #include <PWGUD/DataModel/UDTables.h> |
There was a problem hiding this comment.
This should stay under "", not <>
| #include "PWGUD/DataModel/UDTables.h" | ||
| #include <PWGUD/DataModel/UDTables.h> | ||
|
|
||
| #include <CommonConstants/MathConstants.h> |
There was a problem hiding this comment.
Why you delete MathConstants.h include, it is used for PI definition on L196 no?
|
|
||
| // check that all pairs are mu+mu- | ||
| if (std::abs(McPart1.pdgCode()) != kMuonPDG && std::abs(McPart2.pdgCode()) != kMuonPDG) | ||
| if (std::abs(McPart1.pdgCode()) != PDG_t::kMuonMinus || std::abs(McPart2.pdgCode()) != PDG_t::kMuonMinus) { |
There was a problem hiding this comment.
Don't use PDG_t when comparing to tables made within O2. To make sure you the numbers are always compatible, use Serviceo2::framework::O2DatabasePDG pdg;
3 participants
