Skip to content

chore: enable TypeScript strict mode - #1103

Open
antfubot wants to merge 1 commit into
Akryum:mainfrom
antfubot:chore/typescript-strict-mode
Open

antfubot wants to merge 1 commit into
Akryum:mainfrom
antfubot:chore/typescript-strict-mode

Conversation

@antfubot

Copy link
Copy Markdown
Contributor

Why

The compiler ran with strict: false, so a large class of type errors (implicit any, nullable access, unsound casts) went uncaught. This turns on strict and resolves every error it surfaced, tightening the public type surface without changing runtime behaviour.

What

  • Enable "strict": true in the root tsconfig.json.
  • Migrate all 15 affected source files to satisfy strict checks: type previously-implicit any parameters, guard nullable DOM/instance access, make EventListeners.addTriggers generic over the trigger union, narrow ComputePositionConfig, and add PropType/slot-data types to the components and directives.
  • Export the directive/slot types that now appear in emitted declarations so .d.ts generation stays valid.

Verification

  • pnpm typecheck (root tsc) and pnpm -C packages/floating-vue typecheck (vue-tsc) both pass.
  • pnpm test — build succeeds, 31/31 tests pass.
  • pnpm lint passes.

This PR was created with the help of an agent.

@netlify

netlify Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for v-tooltip ready!

Name Link
🔨 Latest commit 979f779
🔍 Latest deploy log https://app.netlify.com/projects/v-tooltip/deploys/6aa267384f505e000831f816
😎 Deploy Preview https://deploy-preview-1103--v-tooltip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant