Skip to content

--auto-accept-architect defaults to True, so architect edits apply without confirmation | #5748

Description

@tiagovilasboas

Static review of public source at commit 5dc9490bb35f. No traffic was sent to any Aider environment.

Architect mode’s confirmation gate is off by default at the CLI:

aider/args.py:

group.add_argument(
    "--auto-accept-architect",
    action=argparse.BooleanOptionalAction,
    default=True,
    help="Enable/disable automatic acceptance of architect changes (default: True)",
)

aider/coders/architect_coder.py only prompts when the flag is false:

if not self.auto_accept_architect and not self.io.confirm_ask("Edit the files?"):
    return
# ... editor_coder.run(with_message=content, preproc=False)

So the default architect path applies editor changes without an “Edit the files?” stop. Users who expect agentic edits to be gated (similar to other tools’ needs_approval defaults) can be surprised; --no-auto-accept-architect exists but is opt-in safety.

Suggested change:

  • Default --auto-accept-architect to False (safe default), keep --auto-accept-architect for the current fast path; or
  • Keep the default but print a one-time startup notice when architect mode is active with auto-accept on.
  • Document the flag next to other confirmation controls (--yes-always).

Severity: low / insecure default for a privileged edit path; intentional UX tradeoff. Defense-in-depth. No proof-of-concept.

Happy to send a focused PR if useful.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions