Repository navigation
Conversation
Contributor
总体结论:修改后合并
[P2] 「放弃未保存更改」的确认回来时,还得看看弹窗是不是原来那个。 AppModal 在弹确认之前检查是否正在提交;等用户点完才回来时,却会直接关窗。等确认期间如果父组件开始保存,或者关闭后打开了另一份编辑,旧确认仍可能把正在保存的窗、甚至另一份编辑关掉。连续触发关闭也没有共用同一次确认。 建议每次打开只允许一个待决确认,确认回来后核对还是同一次打开、并且没在提交,再关窗。首批迁移的弹窗还没用 不替新窗口按关闭的 dot酱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
@/components/ui、@/composables/useConfirm),收口弹窗尺寸/标题栏避让/提交锁定/未保存关闭确认、页面表面自定义背景适配与加载/错误/空态展示。UniversalPlanCreateDialog、AppearanceDescriptionModal、SettingsLeaveModal、QueueDeleteButton、history/index.vue、BAAHScriptEdit.vue),验证既有业务无破坏兼容。mas-frontend-ui和mas-frontend-standardsSkills,供后续页面开发与 P1/P2 迁移直接复用。证据
静态与单测验证
vp lint .:0 errors,0 warnings(1124 个文件)。vp fmt . --check:全部通过(1189 个文件)。vue-tsc -p tsconfig.app.json --noEmit:0 errors。vp test run src/composables/useConfirm.test.ts src/i18n/locales.test.ts:4/4 通过。prefers-color-scheme仅存在于useTheme.ts。dirty嵌套确认):确认maskTop=32、modalTop=48且弹窗与嵌套确认打开期间 32px 标题栏按钮均可点击。Playwright 前后对比(
55dacc670->f7667b3a9)1.
UniversalPlanCreateDialog(960×560 · 浅色)width=520px,top=48px,centered=falseAppModal (size="sm"):width=480px,top=164px,centered=true,destroyOnClose,submitting自动锁定关闭55dacc670)f7667b3a9)2.
AppearanceDescriptionModal(960×560 · 浅色)width=520px,top=48px,centered=false, 硬编码z-index: 90AppModal (size="sm"):width=480px,top=163px,centered=true, 统一z-index: 100055dacc670)f7667b3a9)3.
QueueDeleteButton高危确认(960×560 · 浅色)Modal.useModal().confirm(),无统一app-confirm-modal类与按钮防重入ConfirmActionButton (risk="high")+useConfirm(modal),统一描边警告图标与异步防重入 loading55dacc670)f7667b3a9)其余 4 组等价重构对比截图(SettingsLeaveModal / history / PageSurface / BAAHScriptEdit)
4.
SettingsLeaveModal(960×560 · 深色,等价收敛至AppModal)55dacc670)f7667b3a9)5.
history/index.vue(1280×720 · 自定义背景,AppPage + PageHeader + StateView,减少 52 行)55dacc670)f7667b3a9)6.
PageHeader + PageSurface(1280×720 · 自定义背景,收编.app-page-surface统一阴影/间距 Token)55dacc670)f7667b3a9)7.
BAAHScriptEdit.vue(1280×800 · 浅色,ConfigEditShell + SectionCard plain)55dacc670)f7667b3a9)合并风险
Door: 双向门
仅新增共享 UI 基座与少量页面试点替换,现有
PageHeader/PageSurface/NoData/SectionCard保持向下兼容。Blast Radius: 中
除新建的
@/components/ui原语外,触及PageHeader、PageSurface、NoData、SectionCard及 6 个试点视图;未改动后端接口、配置 schema 或既有遥测归属。